<#956 Only use localhost registry for dev-version ...
# flyte-github
a
#956 Only use localhost registry for dev-version default image Pull request opened by pingsutw Summary • Previously, a released Flyte SDK pointed at a localhost endpoint would pick up the localhost registry (
localhost:30000
) for the default image. Released SDKs should always pull the default image from
<http://ghcr.io/flyteorg|ghcr.io/flyteorg>
— only dev versions (which don't exist on the public registry) should fall back to the localhost registry. • Restrict the localhost-registry swap in
Image._get_default_image_for
to
dev_mode
only. • Add tests covering released vs. dev version × localhost vs. remote endpoint, and the
install_flyte=False
path. Test plan •
uv run pytest tests/flyte/test_image.py -k "default_image_uses or get_base_registry"
— all pass • Released SDK pointed at a localhost demo cluster uses
<http://ghcr.io/flyteorg|ghcr.io/flyteorg>
for the default image • Dev SDK pointed at localhost still uses
localhost:30000
flyteorg/flyte-sdk