#7143 fix: set isDir to true when upload dir
Pull request opened by
machichima
Tracking issue
Why are the changes needed?
What changes were proposed in this pull request?
When flytecopilot upload directory, we should set isDir to true for coreutils.MakeLiteralForBlob, so downstream task can parse its output correctly.
Originally we will get this error when set container task output as "Dir" :
Error converting input 'greeting_dir':
Literal value: scalar {
blob {
metadata {
type {
}
}
uri: "
s3://bucket/iz/testorg/testproject/development/rnrk5xkrhj7g9gfkr5w9/eur05tom4dfe8j4t3obyux2qc/1/9k/rnrk5xkrhj7g9gfkr5w9-eur05tom4dfe8j4t3obyux2qc-0/greeting_dir"
}
}
Expected Python type: <class 'flyte.io._dir.Dir'>
Exception: Expected multipart, received 0
How was this patch tested?
Build the copilot image locally
docker buildx build -f Dockerfile.flytecopilot -t
ghcr.io/machichima/flytecopilot:dev --push .
Labels
Please add one or more of the following labels to categorize your PR:
•
added: For new features.
•
changed: For changes in existing functionality.
•
deprecated: For soon-to-be-removed features.
•
removed: For features being removed.
•
fixed: For any bug fixed.
•
security: In case of vulnerabilities
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.
Related PRs
Docs link
•
main
•
#6583
•
fix: set isDir to true when upload dir 👈
flyteorg/flyte