<#7130 fix: sanitize generatedName in tasklog temp...
# flyte-github
a
#7130 fix: sanitize generatedName in tasklog template to be DNS-1123 compatible Pull request opened by pingsutw Summary • Sanitize the
generatedName
template variable with
ConvertToDNS1123SubdomainCompatibleString
before substitution in tasklog templates • The
generatedName
can contain underscores when derived from Python task names (e.g.
oregon_small_aoi-my_task-0
), which causes issues when used in log URLs expecting DNS-compatible names • The fix is applied at the template substitution point only, so the raw output prefix and other downstream usages are unaffected • Note: the K8s plugin manager already converts pod names to DNS-1123 compatible format (
flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go
), so the actual pod name will not have underscores. The
generatedName
template variable should match the sanitized pod name to ensure log URLs resolve correctly. Test plan • Added unit tests for underscore sanitization, uppercase lowercasing, and already-valid names • Existing tests continue to pass Rollout plan • Standard rollout, no feature flags needed Rollback plan • Revert the PR •
main
• #6583 • fix: sanitize generatedName in tasklog template to be DNS-1123 compatible 👈 flyteorg/flyte