#7127 refactor settings api to be simpler and more type safe
Pull request opened by
afbrock
Why are the changes needed?
The previous API was clunky when we went to start using it, so before it gets any adoption we are changing the interface to be simpler, easier to understand and use, and type safe.
What changes were proposed in this pull request?
This PR removes the 'raw' unstructured APIs and instead only allows get/getForEdit/Update using the structured and typed settings message.
How was this patch tested?
Unit tests and devbox testing with the included buf curl scripts. (along with the cloud pr:
https://github.com/unionai/cloud/pull/15164 )
Labels
Please add one or more of the following labels to categorize your PR:
•
added: For new features.
•
changed: For changes in existing functionality.
•
deprecated: For soon-to-be-removed features.
•
removed: For features being removed.
•
fixed: For any bug fixed.
•
security: In case of vulnerabilities
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.
Related PRs
Docs link
•
main
•
#6583
•
refactor settings api to be simpler and more type safe 👈
flyteorg/flyte