<#7112 [V2] prevent update DB if already terminate...
# flyte-github
a
#7112 [V2] prevent update DB if already terminated Pull request opened by machichima Tracking issue Why are the changes needed? Keep getting slow SQL error in manager log What changes were proposed in this pull request? Prevent update action in DB if already terminated, to prevent duplicate update Alternatives 1. Add label to CR after persisted • We can add a new label to CR after it's successfully persisted • Cons: • Update the CR outside the controller, can be harder to maintain as CR will be updated in different places How was this patch tested? Run locally and ensure there's no "slow SQL" error Labels Please add one or more of the following labels to categorize your PR: • added: For new features. • changed: For changes in existing functionality. • deprecated: For soon-to-be-removed features. • removed: For features being removed. • fixed: For any bug fixed. • security: In case of vulnerabilities This is important to improve the readability of release notes. Setup process Screenshots Check all the applicable boxes • I updated the documentation accordingly. • All new and existing tests passed. • All commits are signed-off. Related PRs Docs link •
main
• #6583 • [V2] prevent update DB if already terminated 👈 flyteorg/flyte