<#7108 fix: pin docker-registry haSharedSecret to ...
# flyte-github
a
#7108 fix: pin docker-registry haSharedSecret to avoid sandbox manifest churn Pull request opened by pingsutw Tracking issue N/A Why are the changes needed? Every time
make sandbox-build
is run,
docker/sandbox-bundled/manifests/complete.yaml
and
dev.yaml
show as modified in git — even when no deployment configuration has changed. This creates unnecessary noise in
git status
and risks accidental commits of non-functional changes. What changes were proposed in this pull request? The docker-registry Helm subchart generates a random
haSharedSecret
via
randAlphaNum 16
when
secrets.haSharedSecret
is not set. This also changes the
checksum/secret
annotation on every run. The fix pins
secrets.haSharedSecret
to a static value (
flytesandboxsecret
) in
charts/flyte-sandbox/values.yaml
. This is safe since the sandbox is a local development environment, not a production deployment. Changed files: •
charts/flyte-sandbox/values.yaml
— added static
secrets.haSharedSecret
•
docker/sandbox-bundled/manifests/complete.yaml
— regenerated with pinned secret •
docker/sandbox-bundled/manifests/dev.yaml
— regenerated with pinned secret How was this patch tested? Ran
make -C docker/sandbox-bundled manifests
twice consecutively and confirmed the generated manifests are identical between runs (no diff). Labels • fixed: For any bug fixed. Check all the applicable boxes • I updated the documentation accordingly. • All new and existing tests passed. • All commits are signed-off. •
main
• #6583 • fix: pin docker-registry haSharedSecret to avoid sandbox manifest churn 👈 flyteorg/flyte