#6956 [V2] Add Internal run service Pull request opened by machichima Tracking issue Why are the changes needed? Run service should only watch/update the DB, rather than using the action service client. This PR make run service fully depends on the DB, and add the internal run service for other service (action service) to call for persisting data to DB. What changes were proposed in this pull request? • Add

runs/service/internal_run_service.go

, which contains the internal run service implementations • Update

runs/service/run_service.go

to only update / watch the DB, and remove the usage of action client •

actions/k8s/client.go

will call internal run service method to record action/action event • Add

ActionEvent

table (

runs/repository/models/action_event.go

) Fixes • Update the

Phase

in the

Action

table from string to int, being able to parse from

ActionPhase

enum rather than hard coding

PHASE_....

How was this patch tested? • Follow the development guide in

manager/DEVELOPMENT.md

to start single binary locally, and run example through flyte-sdk • flyte-sdk

.wait

can get the phase update correctly image •

TaskAction

CR completed image • Data persisted to DB correctly Actions: image ActionEvents: image Labels Please add one or more of the following labels to categorize your PR: • added: For new features. • changed: For changes in existing functionality. • deprecated: For soon-to-be-removed features. • removed: For features being removed. • fixed: For any bug fixed. • security: In case of vulnerabilities This is important to improve the readability of release notes. Setup process Screenshots Check all the applicable boxes • I updated the documentation accordingly. • All new and existing tests passed. • All commits are signed-off. Related PRs Docs link •

main

• #6583 • #6956 👈 flyteorg/flyte