<#712 bugfix: use correct field name for app metri...
# flyte-github
a
#712 bugfix: use correct field name for app metrics protocol Pull request opened by cosmicBboy This pull request fixes a bug in the serialization of scaling metrics to protobuf by ensuring that the correct field (
target_value
) is used instead of the incorrect field (
val
). It also updates the related unit tests to verify the correct serialization behavior. Bug fix: Scaling metric serialization • Updated
_get_scaling_metric
in
app_serde.py
to serialize
Scaling.Concurrency
and
Scaling.RequestRate
metrics using the
target_value
field, as expected by the protobuf definitions, instead of the incorrect
val
field. Testing improvements • Modified tests in
test_app_serde.py
to verify that the
target_value
field is correctly set in the resulting protobuf objects for both
Concurrency
and
RequestRate
metrics, replacing previous tests that documented the bug. flyteorg/flyte-sdk