<#694 fix: app spec merges image and pod template>...
# flyte-github
a
#694 fix: app spec merges image and pod template Pull request opened by cosmicBboy This pull request updates the pod specification serialization logic to improve how container images are determined and merged, especially when using a pod template. It ensures the primary container's image is set appropriately based on
app_env.image
, and adds comprehensive tests to verify this behavior. Improvements to container image resolution: • Updated
_serialized_pod_spec
in
src/flyte/app/_runtime/app_serde.py
to merge
app_env.image
into the primary container if its image is not set, supporting
"auto"
and explicit image values, while preserving explicit container images. Testing enhancements: • Added three new tests to `tests/flyte/app/runtime/test_app_serde.py`: • Test that the primary container inherits
app_env.image
when no image is set in the pod template. • Test that an explicit image in the pod template's primary container is not overwritten by
app_env.image
. • Test that
app_env.image="auto"
results in a default image for the primary container when no image is set. flyteorg/flyte-sdk