<#6810 [Run Service] Refactor runservice> Pull req...
# flyte-github
a
#6810 [Run Service] Refactor runservice Pull request opened by machichima ## Tracking issue ## Why are the changes needed? Currently we only have
postgres.go
,
models.go
, and
interface.go
in
repository/
. If we want to add new DB model (e.g.
task
), we can only put into those files, making them larger and larger. Therefor, it's better to split them into files for different objects. ## What changes were proposed in this pull request? • Refactor run service structure to make it more organized and easier to add new elements • `interfaces/`: Put the interfaces for different components • `models/`: DB models • `impl/`: DB implementation ## How was this patch tested? Run
make build
and
make run
, ensure things can start successfully [image](https://private-user-images.githubusercontent.com/60069744/529153241-e7ed2e5b-f4bc-46c7-b200-1c59ba8de2b1.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjY0NTMzNTAsIm5iZiI6MTc2NjQ1MzA1MCwicGF0aCI6Ii82MDA2OTc0NC81MjkxNTMyNDEtZTdlZDJlNWItZjRiYy00NmM3LWIyMDAtMWM1OWJhOGRlMmIxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTEyMjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUxMjIzVDAxMjQxMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdkM2JiNmE0ZWYxMjdkMmQ2ZmQwNGM2MWVmMzMyOWEzZDZjNjVkYmNhMjg5MTdlYmM5MTI3ZGMzYTM1ODg0N2ImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.VzVG1LovwIGf514NR_6bToSQxaX7iRk7Z8Z784j6SoI) ### Labels Please add one or more of the following labels to categorize your PR: • added: For new features. • changed: For changes in existing functionality. • deprecated: For soon-to-be-removed features. • removed: For features being removed. • fixed: For any bug fixed. • security: In case of vulnerabilities This is important to improve the readability of release notes. ### Setup process ### Screenshots ## Check all the applicable boxes • I updated the documentation accordingly. • All new and existing tests passed. • All commits are signed-off. ## Related PRs ## Docs link flyteorg/flyte