<#6670 removed unnecessary ignore lint> Pull reque...
# flyte-github
a
#6670 removed unnecessary ignore lint Pull request opened by hamersaw ## Tracking issue N/A ## Why are the changes needed? The latest buf (v1.58) complains about having an unnecessary ignore in the oneof. The
ignore
is automatically implied in a
oneof
via https://protovalidate.com/reference/rules/message_rules/#oneof. "Note that adding a field to a oneof will also set the IGNORE_IF_ZERO_VALUE on the fields. This means only the field that is set will be validated and the unset fields are not validated according to the field rules. This behavior can be overridden by setting ignore against a field." ## What changes were proposed in this pull request? ^^^ ## How was this patch tested? Ran
buf lint --exclude-path flytestdlib
locally and observed failure, remove
ignore
and it passed. ### Labels Please add one or more of the following labels to categorize your PR: • changed: For changes in existing functionality. This is important to improve the readability of release notes. ### Setup process ### Screenshots ## Check all the applicable boxes • I updated the documentation accordingly. • All new and existing tests passed. • All commits are signed-off. ## Related PRs ## Docs link flyteorg/flyte