:wave: looks like there was a recent change to cha...
# contribute
g
👋 looks like there was a recent change to charts to allow for configuring probes at https://github.com/flyteorg/flyte/pull/6484. But I think grpc_health_probe has been in use for a very very long time. Has anyone considered not shipping grpc health probe at all... and instead relying on built-in k8s grpc health checks instead? https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#define-a-grpc-liveness-probe The current script checks both HTTP and gRPC as part of the healthcheck -- but I think it could be simplified to just checking grpc (given grpc-gateway provides both transports) to remove that dependency. Thoughts @average-finland-92144?
c
They should definitely be using the native probe configuration if possible, i'm guessing it looks the way it does for historical reasons
g
That was my assumption as well