docker run --rm -it <http://cr.flyte.org/flyteorg/datacatalog-release:v1.16.0|cr.flyte.org/flyteorg/datacatalog-release:v1.16.0> /bin/sh
/ $ vi /tmp/otel.yaml
/ $ cat /tmp/otel.yaml
otel:
  file: /tmp/trace.txt
  jaeger:
    endpoint: <http://localhost:14268/api/traces>
  otlpgrpc:
    endpoint: <http://localhost:4317>
  otlphttp:
    endpoint: <http://localhost:4318/v1/traces>
  sampler:
    parentSampler: always
  type: noop
/ $ datacatalog --config /tmp/otel.yaml migrate run
INFO[0000] Using config file: [/tmp/otel.yaml]
Error:

1 error(s) decoding:

* 'file' expected a map, got 'string'

Looks like at a glance the new otel config in the helm chart doesn't match what the various components are expecting.

Cc @clean-glass-36808

https://github.com/flyteorg/flyte/blame/7b7bc7c26e1e6235af71fb11516580d498e09e09/flytestdlib/otelutils/config.go#L64 Yeah, this suggests it should be

otel:
  file:
    filename: /tmp/trace.txt

I think you can drop the default OTEL values from the helm chart values to work around for now. I think it unconditionally renders it and then only uses them if the type is configured

Yeah, we can work around, but y'all might wanna fast release a fix, this definitely breaks using the helm chart

In our fork where we use OTEL I don't have the defaults rendering out like that which is probably we we didn't catch it (we just use otel gRPC)

Yeah, we just put the

filename:

version in our configmap and things seem fine, or at least, we get past this

@average-finland-92144 you wanna stamp it?

Thanks for the quick fix 🙏

I pushed helm chart v1.16.1. Will try to make an official release soon but this should unblock.

Thank you!