<#3303 Restore behavior passing FlyteClient kwargs...
# flyte-github
a
#3303 Restore behavior passing FlyteClient kwargs to gRPC channel creation Pull request opened by clint-stripe ## Why are the changes needed? The
FlyteRemote
class is documented as allowing gRPC options in the https://github.com/flyteorg/flytekit/blob/v1.16.3/flytekit/remote/remote.py#L284-L285. These are still passed through to client construction, though we stopped passing these to the underlying gRPC channel creation in #1458. (It's not clear to me if this was an oversight or intentional decision?) This does mean that from v1.10.0 onward, there's no longer any way to provide additional options for the gRPC channel. We have a custom proxy that requires additional gRPC options to be set at channel creation time (specifically,
grpc.default_authority
, though I can imagine others may be useful too). Unfortunately, it's not possible to configure this at any other point (e.g. with an interceptor). ## What changes were proposed in this pull request? This PR restores the previous (and still-documented) behavior. ## How was this patch tested? I added a unit test to ensure we're keeping the default options as well as adding any user-provided options. I've also tested with this change internally and it works with pre-1.10.0 code that has the desired behavior. ### Setup process ### Screenshots ## Check all the applicable boxes • I updated the documentation accordingly. • All new and existing tests passed. • All commits are signed-off. ## Related PRs ## Docs link https://bito.ai#summarystart| ### Summary by Bito This pull request restores the ability to pass additional gRPC options when creating the gRPC channel in the FlyteClient, addressing a regression from a previous update. It ensures compatibility with both default and user-provided options, and includes a unit test to verify the functionality. flyteorg/flytekit