<#6611 [FEAT] set name max length for rayJob plugi...
# flyte-github
a
#6611 [FEAT] set name max length for rayJob plugin Pull request opened by machichima ## Tracking issue ## Why are the changes needed? When using rayjob, if the name > 47, the rayjob will fail the validation (https://github.com/ray-project/kuberay/blob/d59cbd8901c498b17bac728be54189214fea3f30/ray-operator/controllers/ray/utils/constant.go#L232C24-L232C47) The Flyte hash name criteria is set to 50 char, which will not hash the name if > 47 and cause error flyte/flytepropeller/pkg/controller/nodes/task/taskexec_context.go Line 33 in</flyteorg/flyte/commit/5f2646126bbb0f3e67869b82d63c3c8785e8732c|5f26461> | const IDMaxLength = 50 | | ---------------------- | [image](https://private-user-images.githubusercontent.com/60069744/485281415-b66988a3-32b7-4b11-a23c-b0c9a590a686.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTcxMTA3NDgsIm5iZiI6MTc1NzExMDQ0OCwicGF0aCI6Ii82MDA2OTc0NC80ODUyODE0MTUtYjY2OTg4YTMtMzJiNy00YjExLWEyM2MtYjBjOWE1OTBhNjg2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA5MDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwOTA1VDIyMTQwOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdmYzAzMGUzMWZiYjNmZTU2NmI2NjNkODRmOGM3NmIwN2Q0NmIzNzZiMTllYzQ2NjhmMTZhMWYwOWFmNGNkYWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.6hdaq6Nm3M5m7SoCCQDe4pwRm6Djc-V16gErLqVCwdc) ## What changes were proposed in this pull request? Set
GeneratedNameMaxLength
for ray plugin to 47, ensure the rayjob name is hashed if > 47 ## How was this patch tested? ### Labels Please add one or more of the following labels to categorize your PR: • added: For new features. • changed: For changes in existing functionality. • deprecated: For soon-to-be-removed features. • removed: For features being removed. • fixed: For any bug fixed. • security: In case of vulnerabilities This is important to improve the readability of release notes. ### Setup process ### Screenshots Result, the rayjob name is hashed [image](https://private-user-images.githubusercontent.com/60069744/485282396-829fead5-8568-4fad-8044-6c168b546e13.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTcxMTA3NDgsIm5iZiI6MTc1NzExMDQ0OCwicGF0aCI6Ii82MDA2OTc0NC80ODUyODIzOTYtODI5ZmVhZDUtODU2OC00ZmFkLTgwNDQtNmMxNjhiNTQ2ZTEzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA5MDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwOTA1VDIyMTQwOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM5NjI0NDkwNDVhYzI2MTVlZDA3NmQxMzQwZDU2MmM1NTBkYjY0NDEzMTE2OTc1ODM0OTY3NWU5MTBlNTgxZTkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.uswbeaZOhzdof0JOHvNUKrhDZPxVBm3OviT0nvmR78c) ## Check all the applicable boxes • I updated the documentation accordingly. • All new and existing tests passed. • All commits are signed-off. ## Related PRs ## Docs link https://bito.ai#summarystart| ### Summary by Bito This pull request introduces a feature that sets the maximum length for generated names in the ray job plugin to 47 characters, ensuring compliance with ray job validation. It aligns the Flyte hash name criteria with the validation requirements. flyteorg/flyte