I'd like to push on moving to Go 1.23 again: <http...
# contribute
c
I'd like to push on moving to Go 1.23 again: https://github.com/flyteorg/flyte/pull/6249 • Go 1.25 is out now • There's 48 security alerts on the repo and I believe most if not all of them cannot be addressed because the project is still on Go 1.22 (I've tried) • Stack AV has been using Go 1.23 in production for 7 months now Other folks in the community want this landed and from what I understand Union is hard forked so I don't see an compatibility issues.
šŸ™ 1
highfive 1
šŸ™ 1
f
@clean-glass-36808 lets go and merge this one then
should we go to 1.25?
can you fix the unit test for admin?
c
Yeah I'll take a look and ping when its fixed
I'd like to get to 1.25 at some point after. This will unblock some of the security issues and once I work through those I'll put up a PR for 24/25
I think the flyte admin unit test failure is a flake because its not using a test clock, will trigger a re-run
Alright its green on a re-run
Alright this is landed, thanks folks
f
Wooohioo
g
Can we get a release cut on top of 1.23, or should we wait for the 1.24 variant? (Flytectl also needs to be cut)
c
1.24 might take a little bit because we want to test it in production at Stack for a bit
g
Makes sense -- getting the 1.23 based release cut would be super helpful. Our scanners are getting pretty grumpy šŸ™‚
c
I saw v.1.16 was cut but it doesn't seem like this made the cut
f
What happened
c
Just mentioning to @gorgeous-waitress-5026 that it looks like v1.16 was cut: https://github.com/flyteorg/flyte/commit/3a102b9f4f9b83a150a01d885df1654d89561ce7 But the PR to upgrade to Go v1.23 doesn't seem to be in there
f
Cc @glamorous-carpet-83516 @thankful-minister-83577 did we just cut for flytekit
c
Maybe the changelog is just bugged since it looks like it was generated against
v1.16.0b0
Its comparing these https://github.com/flyteorg/flyte/compare/flytectl/v0.9.5...v1.16.0b0 which is weird, yeah that must be it
t
we cut flytekit yesterday
the flyte 1.16 release is running now.
šŸ‘ 1
c
Just comparing to when v1.15.0 was cut it looks like the release notes aren't right
So it would be good to fix that before creating the release
t
mmm
yeah we will update
not sure how this happened apologies, we were going a bit too quick yesterday - it's just click-copied from github's release note generator
šŸ‘ 1
g
Cool - thanks for the heads up! Will try and run things through tomorrow