<#5773 [Core feature] Force `SecretsManager.get` t...
# flyte-github
c
#5773 [Core feature] Force
SecretsManager.get
to be keyword only
Issue created by thomasjpfan ### Motivation: Why do you think this is important? It's becoming fairly common to have users write
secrets.get("my_key")
and assume that its the key. For example: https://github.com/flyteorg/flytekit/pull/2767/files ### Goal: What should the final outcome look like, ideally? I propose we define
SecretsManager.get
with a
*
to make it keyword only: def get( self, *, group: Optional[str] = None, key: Optional[str] = None, group_version: Optional[str] = None, encode_mode: str = "r", ) -> str: This is backward breaking, so we can go through a deprecation cycle before converting to keyword only. ### Describe alternatives you've considered There are no alternatives ### Propose: Link/Inline OR Additional context No response ### Are you sure this issue hasn't been raised already? • Yes ### Have you read the Code of Conduct? • Yes flyteorg/flyte