<#6526 Enqueue correct work item in node execution...
# flyte-github
c
#6526 Enqueue correct work item in node execution context Pull request opened by Sovietaced ## Tracking issue Closes #6525 ## Why are the changes needed? Previously this code would attempt to enqueue the broad workflow identifier as opposed to the execution namespace & execution ID. As a result the logs would be spammed with the following WARNING log being spammed:
Workflow namespace[]/name[<project>:<domain>:<wf_name>] not found, may be deleted
where <> were substituted for real values. The namespace was always empty and the execution ID was incorrect. This behavior likely wasn't a major issue due to the eventually consistent nature of the shared informer and how it regularly queues workflows for processing. This pull request updates the code to enqueue the Flyte workflow k8s resource name & namespace which is what Flyte propeller expects since it operates on the flyteworkflows custom resource. This should make Flyte propeller process enqueued workflows as originally intended, resulting in faster results and no more log spam. ## What changes were proposed in this pull request? 1. Enqueue workflows using the Flyte workflow k8s resource name and namespace. 2. Remove the warning log in
passthrough
since we're returning an error. Generally we should log and also return errors, we should log errors at the latest point where we handle them so the error is printed only once. ## How was this patch tested? 1. Unit test 2. In our production environment ## Check all the applicable boxes • I updated the documentation accordingly. • All new and existing tests passed. • All commits are signed-off. ## Related PRs ## Docs link https://bito.ai#summarystart| ### Summary by Bito This pull request enhances the workflow enqueueing mechanism in the Flyte propeller by ensuring the correct Kubernetes resource name and namespace are used, resolving a logging issue that caused spam warnings, which reduces warning logs and improves processing speed. Unit tests have been updated to validate these changes. flyteorg/flyte