<#3280 make ngc image secret optional> Pull reques...
# flyte-github
c
#3280 make ngc image secret optional Pull request opened by samhita-alla ## Tracking issue ## Why are the changes needed? these changes are required for the private registry support we rolled out with image spec. if
ngc_image_secret
is specified, we still go the old route. if the user provides the image pull secret as a secret and adds builder options to the image spec, we don't need to specify the image pull secret in the pod template. ## What changes were proposed in this pull request? made
ngc_image_secret
optional. ## How was this patch tested? tested the NIM plugin by specifying the image pull secret as a flyte secret and adding it to imagespec. ### Setup process ### Screenshots ## Check all the applicable boxes • I updated the documentation accordingly. • All new and existing tests passed. • All commits are signed-off. ## Related PRs ## Docs link https://bito.ai#summarystart| ### Summary by Bito This pull request enhances the NIM plugin by making the 'ngc_image_secret' parameter optional and introducing new builder options for improved private registry support, while maintaining compatibility with the old method. These changes aim to streamline the configuration process for users. flyteorg/flytekit