Can someone help review <https://github.com/flyteo...
# contributes
steep-jackal-21573
03/17/2025, 5:28 PMCan someone help review https://github.com/flyteorg/flyte/issues/6343? Thank you.
g
glamorous-carpet-83516
03/17/2025, 5:52 PMlgtm, thanks
glamorous-carpet-83516
03/17/2025, 6:05 PMone of the test is failing. mind taking a look
s
steep-jackal-21573
03/17/2025, 6:07 PMYeah I was looking at it, but not sure why it failed.
steep-jackal-21573
03/17/2025, 6:17 PMI can't explain why only that one failed. Seems like a flaky test.
w
wonderful-sundown-35324
03/17/2025, 6:17 PMYeah, probably
s
steep-jackal-21573
03/17/2025, 6:17 PMI retriggered the failed job.
steep-jackal-21573
03/17/2025, 6:20 PMNow it passed.
g
glamorous-carpet-83516
03/17/2025, 6:21 PMah, it’s flaky, i see.
glamorous-carpet-83516
03/17/2025, 6:22 PMI think it’s good to merge now, thank you both
s
steep-jackal-21573
03/17/2025, 6:22 PMThis failure is weirder https://github.com/flyteorg/flytekit/actions/runs/13905702236/job/38912145517?pr=3197 😞
g
glamorous-carpet-83516
03/17/2025, 6:22 PMGitHub Actions has encountered an internal error when running your job.
glamorous-carpet-83516
03/17/2025, 6:23 PMseems like a bug in Github, definitely unrelated to your PR
s
steep-jackal-21573
03/17/2025, 6:23 PMYeah I believe so.
steep-jackal-21573
03/17/2025, 6:23 PMIt also doesn't block merging.
g
glamorous-carpet-83516
03/17/2025, 6:24 PMI merged it 😀
s
steep-jackal-21573
03/17/2025, 6:24 PMCool, thank you.
2 Views