Is there any cadence for doing go upgrades?
# contributec
clean-glass-36808
02/15/2025, 3:18 AMIs there any cadence for doing go upgrades?
clean-glass-36808
02/15/2025, 3:19 AMI only bring it up because something we depend on is on go 1.23 and I basically have to do the work for our fork.
f
freezing-airport-6809
02/15/2025, 4:39 AM
What is the thing that is go 1.23
freezing-airport-6809
02/15/2025, 4:39 AM
The thing is testing I think
freezing-airport-6809
02/15/2025, 4:39 AM
If you do it we can take
It
c
clean-glass-36808
02/15/2025, 5:00 AMMakes sense.
f
freezing-airport-6809
02/15/2025, 5:02 AM
Cc @high-accountant-32689 wdyt?
h
high-park-82026
02/17/2025, 4:22 AM
I know go 1.23 has some breaking changes for package loading logic that would break pflags I believe... if you can take that on, that would be great!
c
clean-glass-36808
02/17/2025, 5:04 PMYeah I was looking at that. Also breaks mockery so need to figure that one out too, maybe update your fork.
h
high-accountant-32689
02/18/2025, 3:13 PMfor the fork, we have support for mockery v2 (added in https://github.com/flyteorg/flyte/pull/4937). We had a few contributions from the OSS community to get rid of it recently, so we're very close to getting completely off of the fork. The upstream mockery has support for 1.24.
I'd love to get started on this migration to go 1.23 (in fact, it's not too crazy to start thinking about moving to 1.24), but, as Ketan and Haytham pointed out, making sure that we handle these breaking changes is the bottleneck.
high-accountant-32689
02/18/2025, 4:06 PMAlso, it's not a specific language feature that went out in 1.23 but a dependency that only supports 1.23, right, @clean-glass-36808?
c
clean-glass-36808
02/18/2025, 4:31 PMYep.
3 Views