Should we deprecate the pydantic plugin <https://g...
# contribute
c
Should we deprecate the pydantic plugin https://github.com/flyteorg/flytekit/tree/master/plugins/flytekit-pydantic (pydantic v1) given that 1.14 introduced an official base model type transformer using the new messagepack transport?
d
Yes we should
c
Do we have a process for this? Do we just remove the plugin from the repo and stop publishing new versions?
we only add logs to ask users to remove it
I think yes we can remove it
but afraid that it will affect some OSS users
a
Do we have a process for this?
Not really, but I'd try to phase this out like, in the next release, deprecate it, and remove it in another release; just to give it some time to users to move away from it. wdyt?
c
in the next release, deprecate it
https://github.com/flyteorg/flytekit/pull/2792 added the warning log message “The Flytekit Pydantic V1 plugin is deprecated.” in october which was part of the recent release. Does this mean we can delete it now already?
f
but we should just delete it, it never worked right @damp-lion-88352?
d
yes it never worked
or we can say i worked in a subset
pretty useless usecase
ok I can create a PR to delete this now