https://flyte.org logo
#announcements
Title
# announcements
r

Rahul Mehta

08/29/2022, 2:38 AM
Is there a particular reason that named executions are capped at 20 characters?
Copy code
Error: rpc error: code = InvalidArgument desc = size of name exceeded length 20 : test-named-workflow-2
This appears to be hard-coded here: https://github.com/flyteorg/flyteadmin/blob/7b48c856e3a1e12c57f1abbf535bf6c29fa59d74/pkg/manager/impl/validation/execution_validator.go#L19. Would folks be open to bumping that to 64 (to match the max length for an argo workflow's name)
s

Samhita Alla

08/29/2022, 5:07 AM
cc: @Ketan (kumare3)
k

Ketan (kumare3)

08/29/2022, 6:01 AM
Cc @Haytham Abuelfutuh / @katrina
r

Rahul Mehta

08/29/2022, 3:52 PM
Is there any limitation w/ the database schema for flyteadmin that requires the execution ID is <= 20 chars? Argo's 64-char limitation is a K8s-level restriction vs an argo-specific implementation detail
k

Ketan (kumare3)

08/29/2022, 3:55 PM
I think it was done for k8s
nothing on the db
and also for legibility
r

Rahul Mehta

08/29/2022, 3:56 PM
The max length for k8s workloads/labels is 64 chars -- 20 chars is a bit tight in terms of named executions/can see that being a common user footgun. If it isn't a db-lvl limitation would you either be open to setting to 64 or making it configurable in flyteadmin?
k

Ketan (kumare3)

08/29/2022, 8:40 PM
we can but have to be careful
lets talk cc @katrina / @Haytham Abuelfutuh
👍 1
r

Rahul Mehta

08/29/2022, 8:41 PM
Ya happy to discuss the tradeoffs later today @Ketan (kumare3) -- if shoehorning it into execution ID doesn't make sense, could also introduce a separate varchar field to include a human-readable name
that's separate from execution id
k

Ketan (kumare3)

08/29/2022, 8:41 PM
ya i was thinking we need a label anyways
👍 1
r

Rahul Mehta

08/29/2022, 8:42 PM
Especially if that could then lead to search in the frontend based on labels, think that'd be a great multi-tenancy improvement
👍 1
26 Views