Hi team.. I want to bypass the error caused by duplicate version while registration but want to fail if there are any other errors. Will

continueOnError

suppress real errors?

I believe so. @Prafulla Mahindrakar, can you confirm?

AlreadyExists

is not considered to be an error case in flytectl so continueOnError doesn’t apply to it . yes but you can circumvent the normal errors using that flag

This is the problem I’m running into… In my current branch the only thing I did was change a Makefile that impacts whether the continueOnError flag is used or not.. yet the error I see is this:

/tmp/register3835595043/24_flyte.workflows.some_file.some_wf_2.pb                                    | Failed  | Error registering file due to rpc error: code =         |
|                                                                                                                   |         | InvalidArgument desc = workflow with different          |
|                                                                                                                   |         | structure already exists with id resource_type:WORKFLOW |
|                                                                                                                   |         | project:"my_project" domain:"development"               |
|                                                                                                                   |         | name:"flyte.workflows.some_file.some_wf"   |
|                                                                                                                   |         | version:"141dbf71ef1e878e5527859768d99d5c538a3274"

This says structure is different and hence throws InvalidArgument which is different than AlreadyExists error code which is thrown by admin incase you try to overwrite a version. I guess this should be bucketed still in AlreadyExists . In such a case it expected to change the version you want to register since flyte objects are immutable

that’s the weird part.. the structure is not different.. because I changed absolutely nothing other than a Makefile

The code which throws this is here https://github.com/flyteorg/flyteadmin/blob/master/pkg/manager/impl/workflow_manager.go#L166-L172

thank you.. that helps

So seems byte comparision is showing a diff in workflowDigest which gets computed

workflowDigest, err := util.GetWorkflowDigest(ctx, workflowClosure.CompiledWorkflow)

So there should have been some change.

Can you go a little deeper into how the “workflow digest” is computed?

We use https://github.com/benlaurie/objecthash which uses sha256 under the hood and has very low probability of collision. When you generated an empty commit that would still create i am assuming a new hash and git which will create a new registration version for flyte if you are passing that one.