https://flyte.org logo
Join Slack
Powered by
Hi, anyone have a guess as to why `TypeTransformer...
# announcements
g
Hi, anyone have a guess as to why 
TypeTransformerFailedError
occurs when using imported variables in workflows, but if the variables are declared in the same python module as the workflow there is no error? Thank you!
v
Hi Zachary, thanks for your question. Do you also receive any other error message alongside the TypeTransformerFailedError
g
Nope. I’m avoiding copying/pasting the stack trace for company privacy reasons
I can try and reproduce it in a dummy format if that will help. More details are that the types failing when imported are annotated with @dataclass and @dataclass_json
pseudocode is this: @task tsk(x: list[MyDataclass]) -> None: result = f(x) print(result) @workflow wf(x: list[MyDataclass]) -> None: tsk(x)
if the input for x is defined in the same module as the task/workflow code there’s no error, but when importing identical code (copy/pasted) from a neighbor module, it produces the error
Copy code
File "<redacted>/lib/python3.9/site-packages/flytekit/core/type_engine.py", line 97, in assert_type
    raise TypeTransformerFailedError(f"Type of Val '{v}' is not an instance of {t}")
flytekit-1.1.0
hmm, well, this works: m2.py
Copy code
from flytekit import task, workflow
from m1 import MyDataclass, inputs


def f(x: list[MyDataclass]) -> MyDataclass:
    return x[0]


@task
def tsk(x: list[MyDataclass]) -> None:
    result = f(x)
    print(result)


@workflow
def wf(x: list[MyDataclass]) -> None:
    tsk(x=x)


wf(x=inputs)
m1.py
Copy code
from dataclasses import dataclass

from dataclasses_json import dataclass_json


@dataclass_json
@dataclass
class MyDataclass:
    a: int


inputs = [MyDataclass(1)]
v
So was there a separate implementation in your previous example? because when just importing class, variables it should work.
g
So was there a separate implementation in your previous example?
iiuc, yes, the real code is different than the example code shown here
figured it out. In the real code the equivalent of 
m1.py
is importing dataclasses from a third module (eg. 
m3.py
). If a relative import path is used it produces the 
TypeTransformerFailedError
. If an absolute path is used, it works
@victorious-park-53030, thank you for the help! Do you think this error is the appropriate error when it’s really do to the way flytekit is interpreting types based on import paths?
👍 1
d
Glad you solved it. There is an alternative solution also to append the module path to sys as follows:
Copy code
import sys
sys.path.append('d/modules/')
Then you don't have to worry about relative or absolute path.
🙏 1
👍 1
g
thank you for this @dry-teacher-15656! When I register the workflow on our Flyte cluster, the same error returns although it’s now passing locally. I’m guessing it has something to do with the import paths again, but now that they’re all absolute paths, idk what else to change. Any ideas for things to try?
d
@gray-jordan-61319 Absolutely. One inefficient option is to dump the entire of your code (input and workflow) into one test script. Then run it. Do you think you can do that?
g
ty! I’m assuming that would work, but what would be the long-term solution?
d
If you give that a try. My solution is to use "relative path". This is a very standard option. I attach it here for you to look.
inputModule.py,on_examples.py
inputModule.pyon_examples.py
👀 2
🙏 2
Copy code
@workflow
def new_wf_test():
    new_dynamic_test()
    from core import inputModule # <<<<---- PAY ATTENTION HOW IMPORTED
    print(inputModule.varInt)
    print(inputModule.varString)
    return
Additional in your case I strongly recommend to use bash script like the following
Copy code
#!/usr/bin/env bash
set -e

pyflyte -c ~/.flyte/demo-config.yaml run --service-account demo --remote core/on_examples.py new_wf_test
g
ty! for reference, the full error message is
Copy code
TypeTransformerFailedError: Type of Val 'MyDataset(name='my_name', label=0)' is not an instance of <class 'types.MyDatasetSchema'>
I’m trying to understand what’s causing the error. afaik 
type(MyDataset)
is 
MyDataset
, not 
MyDatasetSchema
. Would you please help me understand why it isn’t checking that the instance is of type 
MyDataset
? (this is for a 
class MyDataset
decorated with @dataclass_json and @dataclass)
t
sorry, still skimming, what is MyDatasetSchema
when a workflow runs locally, flytekit will go through the same serialization/deserialization steps as in production btw.
in either case, when this serde process runs, the class that you get back is not the same.
it’s a dataclass(json) class that looks the same, but it’s not the same
g
ty for explaining! Do you think it’s comparing the dataclass type to the dataclass’s json type and saying they’re not the same?
t
you can see that code here
i’m confused where the string “Schema” is coming from…
g
auto-generated in Flyte’s error msg
t
i don’t think this is something added by marshmallow
maybe it is
g
raise TypeTransformerFailedError(f"Type of Val '{v}' is not an instance of {t}")
L97 for flytekit.core.type_engine
I think it’s doing something like v = type(MyDataset) t = type(MyDataset.to_json)
I’m still pretty sure it has something to do with import paths. Locally, if relative paths were used it would produce this error, but once absolute paths were used, the error went away locally, but not in the Flyte cluster
t
sorry do you have a mvp repro? or did i miss that above?
g
nope. It’s going to be easier for me to convert the dataclasses to dictionaries for workflow input and then convert them back again into dataclasses in the workflow than it will be to create a reproducible example of this. So I will do that, but appreciate everyone looking into this
172 Views
Open in Slack
PreviousNext
Powered by