< fierce oil 47448> < high accountant 32689> can we do the b Flyte #contribute

Join Slack

<@U070XSYA02E> <@U0265RTUJ5B> can we do the backpo...

# contribute

thankful-minister-83577

11/14/2024, 11:20 PM

@fierce-oil-47448 @high-accountant-32689 can we do the backport here? it’s just two prs right?

thankful-minister-83577

11/14/2024, 11:21 PM

i guess 3

thankful-minister-83577

11/14/2024, 11:21 PM

https://github.com/flyteorg/flyte/commit/ab67b4e5f95bae98814bb7b1ba0e3d5a3893544d https://github.com/flyteorg/flyte/pull/5987/files https://github.com/flyteorg/flyte/commit/93f00a117db5478aebe3888ce7175f71a20ca0b2 https://github.com/flyteorg/flyte/commit/f62c7b6dc7df2f260b8ac1cc34d407f11ebc721a

thankful-minister-83577

11/14/2024, 11:36 PM

https://github.com/flyteorg/flyte/pull/6016

thankful-minister-83577

11/14/2024, 11:39 PM

ran

make generate

for flyteidl again, just pushed.

fierce-oil-47448

11/14/2024, 11:42 PM

Thank you @thankful-minister-83577. This looks correct.

fierce-oil-47448

11/14/2024, 11:42 PM

The removal of unused env var is not necessarily needed, but doesn't hurt

thankful-minister-83577

11/15/2024, 1:31 AM

1.13.7 of flyteidl was released btw.

thankful-minister-83577

11/15/2024, 1:32 AM

mind bumping to that?

fierce-oil-47448

11/15/2024, 1:35 AM

Sure, I’ll do that tonight

thankful-minister-83577

11/15/2024, 1:42 AM

will take a look at make setup tomorrow. ran it once.

thankful-minister-83577

11/15/2024, 1:42 AM

but not exactly as i was using uv.

thankful-minister-83577

11/15/2024, 1:43 AM

and was on a different branch. but yeah it should be fine. in any case, any static version shouldn’t be any different than any before it

thankful-minister-83577

11/15/2024, 1:43 AM

but maybe i’m wrong.

fierce-oil-47448

11/15/2024, 6:30 AM

@thankful-minister-83577 Updated to 1.13.7 here: https://github.com/flyteorg/flytekit/pull/2797

fierce-oil-47448

11/15/2024, 6:31 AM

I assume if the tests are good, we should be fine to merge.

Open in Slack

Previous Next