https://flyte.org logo
Join Slack
Powered by
<@UNR3C6Y4T> <@UNW4VP36V> <@U070XSYA02E> I copied ...
# contribute
c
@thankful-minister-83577 @high-park-82026 @fierce-oil-47448 I copied the comments you posted here in the flytekit PR which implements part of the proposed "multi error file" mechanism to the RFC in order to keep the discussion about the mechanism in one place, hope that's ok for you. Are you ok with me deleting your comments in the flytekit PR to reduce noise? I also replied to your questions. Should we 4 maybe have a call to discuss this in person?
f
Sounds good to me. @thankful-minister-83577, @high-park-82026?
t
down to call yeah, and yes to clean up too.
is anyone able to make it to the 11am pacific time normal contributor meeting today? @high-park-82026?
it will probably be a bit later in the meeting, maybe 15 mins in.
f
How often are the contributor meetings? Is the next one a possibility? I am fully booked today.
t
every two weeks.
same time.
c
I can join.
t
let’s find another time to chat about this though when everyone’s available?
when is good for you guys? next monday morning’ish pacific?
f
I am available Monday/Tuesday afternoon PST, if Wednesday is a possibility, then I have a lot of availability on Weds
t
weds good for me, @cool-lifeguard-49380? what tz again are you in @fierce-oil-47448?
c
Next Wednesday works for me as well.
f
Should we set a time?
c
Somewhen in the afternoon would be best for me but if not possible otherwise I can try to shift.
t
11am pacific?
sent. let me know if it doesn’t work
f
Hi @thankful-minister-83577, @cool-lifeguard-49380, @high-park-82026. With the backend changes in, I've updated the flytekit with the latest master here: https://github.com/flyteorg/flytekit/pull/2797
Hi @cool-lifeguard-49380 I think you had some pending comments, which I addressed. @thankful-minister-83577 Would really appreciate if you can help me get this merged, which should make things work end to end.
t
Will merge tomorrow. Sorry I’ve been ooo for a bit
f
Hi Folks, an update here: We tested the error reporting E2E with @cool-lifeguard-49380. Good news: everything works. However, we had to correct stow listing functionality. Can we get this out of the door this week? • Merge the stow listing fixes today: https://github.com/flyteorg/flyte/pull/6013 @thankful-minister-83577 Would appreciate your help with this. • @fierce-oil-47448 to update the flytekit to address review comments today and we can merge tomorrow or later today.
t
+1
will merge when tests pass
f
All the tests passed, but I made some improvements to the multi output file test to use canonical paths. Should have the new test results in an hour. I'll ping when ready.
t
kk
f
Looks like we need a flyteidl release before we can merge in the flytekit changes, based on what @thankful-minister-83577 discovered. cc: @cool-lifeguard-49380
Both backend and flytekit PRs are merged. Thanks @thankful-minister-83577 for your help! I guess we'll need to wait for a flyte + flytekit release that have these changes to see it in action.
t
thank you for all this work, and apologies again for all the back and forth
you have the patience of a monk
c
No worries at all, thanks for helping us get this in 🙂
Are you ok with also merging the rfc pr?
t
yeah ofc
approved the pr - want me to merge?
title needs to be updated.
c
Changed the title 🙂
And merged
🙏
2 Views
Open in Slack
PreviousNext
Powered by