New RunLLM response generated:
>>>*# Question*
Hi, all. I am currently working on this
issue. After a brief discussion with Kevin Su, we found that
Flytekit handles trailing newlines in secrets by removing them, which is consistent with how Flyteadmin handles it in the current implementation. I was wondering if there are any reasons, aside from consistency mentioned in the issue, that we might want to change this behavior. Thanks!
# Answer
Flytekit and Flyteadmin currently handle trailing newlines in secrets by removing them to maintain consistency across the system. This behavior was introduced to avoid potential divergences in how secrets are used in different parts of the system, as noted in
Flyte issue #2559. The primary reason for this change is to prevent unexpected behavior due to the presence of trailing newlines, which can cause issues in authentication and other processes that rely on exact secret values.
If you need more details or have specific scenarios where this behavior might cause issues, please let me know!
Sources:
-
Flyte issue #2559
Slack Link
https://.slack.com/archives/CP2HDHKE1/p1728287604.799599 👍 0 button 👎 0 button 💡
Hint: Mention @runllm in the thread for followups.