Hi, all. I am currently working on this issue. After a brief discussion with Kevin Su, we found that Flytekit handles trailing newlines in secrets by removing them, which is consistent with how Flyteadmin handles it in the current implementation. I was wondering if there are any reasons, aside from consistency mentioned in the issue, that we might want to change this behavior. Thanks!

it's a legacy behavior that we maintained unfortunately... the only way around it will require a feature flag and deprecation notices... etc. @glamorous-carpet-83516 @high-accountant-32689 do you think there is a quick way around that? potentially retrying? Is this issue important to address?

I don't think there's a great way around that. The original PR doesn't mention why this legacy behavior was kept (do you remember, @high-park-82026?). In fact, re-reading the issue I'd be in favor of simply closing it as

Won't fix

.

The thinking was that somebody may have taken a dependency on that behavior (as we did in Lyft) and it will break/surprise them if we remove it...

Got it. That's what I was thinking. In that case, I'm going to close that issue as

Won't fix

since the risks do not outweigh the benefits.

I see. I will close my pr as well. Thanks for the clarification~