👋 is there any way to set workflow labels/annotations for the default launch plan created during registration?

Does it not work? https://github.com/flyteorg/flytekit/blob/cba95fa81df17ffedf57a7e860978c92ae861efc/flytekit/core/launch_plan.py#L195:L210

hey sorry for the delay here! so I tried that but I got this error:

ValueError: Only named launchplans can be created that have other properties.

it seems like we're not able to add labels to the default launch plan, only explicitly named ones

@gentle-night-59824 unfortunately that seem to be the case, after looking at the relevant code it seems like labels are only supported on the default launchplan. Not exactly sure why

iirc there were multiple reasons, not sure how strict they are today. one was because it was difficult to find a natural way to specify it. How would you like to specify it? (like what syntax?) Also there may have been the thought that the default launch plan should be create-able in isolation, with only the workflow definition - if the backend created a default launch plan and flytekit created one, they should be identical.

something like an argument in the

@workflow

would be ideal!

mind making an issue for this?

will do!

i remember the thinking was it wasn’t pure… like the workflow decorator should only affect the workflow, not the launch plan. but I think it’s the right time to revisit that, and maybe be more flexible about it, esp since we already extract out default args to the workflow into the default launch plan as well.

done! 5774