A while back I noticed some unnecessary nil checking code in `flyteadmin`'s gRPC API handlers. I also noticed many many warnings about copying protobuf structs so I finally found some time to fix that up. PR is a bit of a doozy since there was a lot of plumbing of protobuf struct copies: https://github.com/flyteorg/flyte/pull/5717
🚀 5
f
freezing-airport-6809
09/04/2024, 1:25 AM
Cc @acceptable-policeman-57188
👀 1
a
acceptable-policeman-57188
09/04/2024, 2:26 PM
holy guacamole, thank you for this! we explicitly had to disable lint checks because of all the warnings so this is really fantastic for ensuring we can keep the codebase tidy