A couple of core Helm chart improvements that are ...
# contribute
g
A couple of core Helm chart improvements that are ready for review: • Removes the need for the initContainer that calls init-secrets - all of these values can be generated through Helm templates without the need to spin up a container - https://github.com/flyteorg/flyte/pull/5557 • Removes the need for the webhook initContainer used to generate certs - certs can be also be generated through Helm templates - https://github.com/flyteorg/flyte/pull/5558
🔥 1
Tests are failing because some of the chart values are now generated... and re-running a
helm template
will necessarily have different output each time. 2 ways to address this I think: • Ignore these differences in the diffing process • Extend the values.yaml to allow users to specify the values -- and then use to generate with I think the former is more appropriate here
I tried using a naive method of doing the diff using
git diff --word-diff
but it's not quite working