• Anmol

    Anmol

    4 months ago
    Hi, From the UI, I see we currently only fetch 10 launch-plans for a given wf . We have a few users who have > 10 launch-plans and don't have any way of fetching/triggering those via the UI.
  • Guessing this should be easy to bump up . Any concerns if I make a quick PR and set this to say 25 or 50 ?
  • Let me know if I am missing something
  • Ketan (kumare3)

    Ketan (kumare3)

    4 months ago
    cc @Jason Porter
  • cc @Nastya Rusina
  • Nastya Rusina

    Nastya Rusina

    4 months ago
    @User Feel free to bump it to 25-30
  • we will add work for adding “Load more” button in case users will hit limit in future.
  • @Anmol can you please run on your branch locally:
    git rebase HEAD~1 --signoff
    and then push force it again to the brunch. It will add your signature to the PR. I will sign off and merge afterwards
  • Anmol

    Anmol

    4 months ago
    yup, just did . I quickly checked and we have some wfs with ~30-35 launch-plans at Lyft so bumped it to 50 for now. Don't think this should cause any latency/perf issues.
  • Nastya Rusina

    Nastya Rusina

    4 months ago
    Should be fine for now, we will cover it separately, thanks 🙂