• h

    Hank Fanchiu

    2 weeks ago
    er, just some typical
    {"", 0.0}
    . strangely some giant map is likely failing some validation and causing the
    Launch
    button to do nothing.
  • ohhh if the float value has more than 16 digits, then the form is invalid and the task is not launched.
  • i’ve advised my users to use strings instead.
  • separately, i think that:1. the form should display validation errors; 2. the
    Launch
    button should also be disabled until the required inputs are filled with valid values. should these be feature requests in a github issue?
  • Ketan (kumare3)

    Ketan (kumare3)

    2 weeks ago
    I do agree
  • @Jason Porter
  • cc
  • h

    Hank Fanchiu

    2 weeks ago
    lmk if you’d like me to create an issue
  • as well as another issue for handling 17+ digits, if possible?
  • Ketan (kumare3)

    Ketan (kumare3)

    2 weeks ago
    @Hank Fanchiu please create an issue
  • 17+ digits - is the decimal points?
  • h

    Hank Fanchiu

    2 weeks ago
    yeah
  • like
    0.6744571070282204
  • Ketan (kumare3)

    Ketan (kumare3)

    2 weeks ago
    hmm please also write what your ideal way of handling this would be
  • hmm is that a valid float64?
  • h

    Hank Fanchiu

    2 weeks ago
    i suppose that the validation message could just say that the value must be a valid float64
  • hopefully i’ve provided enough details in https://github.com/flyteorg/flyte/issues/2732
  • Jason Porter

    Jason Porter

    2 weeks ago
    Okay thanks @Hank Fanchiu - we'll pick that up on Monday 👍
  • j

    james

    1 week ago
    Right now it seems that it supports 17 digits.. Do you want to support 17+ digits?
  • @Hank Fanchiu
  • Ketan (kumare3)

    Ketan (kumare3)

    1 week ago
    @james the support should be max precision supported by protobuf and not other way around
  • j

    james

    1 week ago
    hmm. sorry, I don’t get you. So the max is 17?
  • Ketan (kumare3)

    Ketan (kumare3)

    1 week ago
    Let's talk offline