acoustic-carpenter-78188
06/21/2024, 9:04 PMkwtypes
is in user code to convert dicts into OrderedDict
. I think this creates another abstraction for users. For APIs, that requires a OrderedDict, they can create it themselves based on the user input.
Even for APIs that require a OrderedDict
, since Python 3.7 the normal dict is required to keep insertion order, so it implicitly behaves like an OrderedDict
. https://mail.python.org/pipermail/python-dev/2017-December/151283.html
What if we do not do this?
Then users will need to learn about kwtypes
and when to use it.
Related component(s)
flytekit
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyte