clean-glass-36808
06/17/2024, 4:18 PMfix
command to run linters across the entire project and have them update files in place?broad-monitor-993
06/17/2024, 4:49 PMclean-glass-36808
06/17/2024, 4:51 PMgoimports
and gci
since I'm working on a backend plugin. I try to run the linter from make
locally but it errors out when it notices I already have some binaries downloaded. Looks like the scripts are designed to be run from a fresh install on CI every time. There may be some room for improvement there too i guessthankful-minister-83577
make goimports
work?thankful-minister-83577
clean-glass-36808
06/17/2024, 5:58 PMmake goimports
does work, although it results in very noisy changes (flytectl, generated files, etc). Ah I see that comes from an imported Makefile
niceclean-glass-36808
06/17/2024, 6:01 PMgoimports
make target...thankful-minister-83577
thankful-minister-83577
thankful-minister-83577
thankful-minister-83577
high-accountant-32689
06/17/2024, 8:03 PMgoimports
in the flyte repo.clean-glass-36808
06/17/2024, 8:04 PMclean-glass-36808
06/17/2024, 8:05 PMgoimports
make target should be abandoned entirely because its just trying (and not successfully) to stay in sync with golangci-lint
configs nestled through the monorepo. So why not just use golangci-lint --fix
which will be completely aligned with CI.high-accountant-32689
06/17/2024, 9:04 PMclean-glass-36808
06/17/2024, 9:09 PM