When using register_script() there is a copy_all o...
# flyte-supportf
fierce-oil-47448
05/31/2024, 8:57 PMWhen using register_script() there is a copy_all option. I want more precise control over what is copied from the source directory. I couldn't find the right option for this.
When I look at the flytekit code, I see that it uses:
Copy code
ignore = IgnoreGroup(source, [GitIgnore, DockerIgnore, StandardIgnore])StandardIgnore Copy code
"""Retains the standard ignore functionality that previously existed. Could in theory
by fed with custom ignore patterns from cli."""t
tall-lock-23197
06/03/2024, 6:29 AM
not sure how we can specify patterns from cli. @high-accountant-32689 since you added this docstring, would like to know if this is possible.
t
thankful-minister-83577
06/04/2024, 10:19 PM
are the docker/gitignore files sufficient?
thankful-minister-83577
06/04/2024, 10:20 PM
if not, what ux are you looking for? how would an api look/work?
f
fierce-oil-47448
06/05/2024, 2:37 AMNot from CLI. I am using FlyteRemote and it should be trivial to add it as an option
fierce-oil-47448
06/05/2024, 2:37 AMI ended up monkey patching one of the classes to make it work for myself.
fierce-oil-47448
06/05/2024, 2:37 AMCC @thankful-minister-83577
t
thankful-minister-83577
06/05/2024, 4:21 AM
mind opening a pr?
thankful-minister-83577
06/05/2024, 4:21 AM
iām sure as long as things are backwards compatible, we can merge in something similar
š 1
f
fierce-oil-47448
06/06/2024, 8:26 AM@thankful-minister-83577 https://github.com/flyteorg/flytekit/pull/2464
fierce-oil-47448
06/10/2024, 8:53 AMHi @thankful-minister-83577 Would it be possible to have someone take a look at the contribution above?
t
thankful-minister-83577
06/10/2024, 4:21 PM
yes
ā
1
f
fierce-oil-47448
06/12/2024, 6:14 PMHi @thankful-minister-83577, I've updated the PR. Would it be possible to get this into the next release perhaps? Not sure when that would be.
t
thankful-minister-83577
06/12/2024, 6:17 PM
tyty
21 Views