Hey👋 I’m trying to upgrade to flyte 1.10.7 using helm chart, and got:

Error: template: flyte-core/charts/flyteagent/templates/agent/deployment.yaml:17:17: executing "flyte-core/charts/flyteagent/templates/agent/deployment.yaml" at <include "flyteagent.podLabels" .>: error calling include: template: flyte-core/templates/_helpers.tpl:122:16: executing "flyteagent.podLabels" at <.Values.flyteagent.podLabels>: nil pointer evaluating interface {}.podLabels

The context is that in the

value.yaml

, I set

flyteagent:
  enabled: true

While if I remove the

flyteagent

section in

value.yaml

, it got successfully deployed. I’m wondering if it’s relevant to the

podLabels

is not configured in the default values here: https://github.com/flyteorg/flyte/blob/master/charts/flyte-core/values.yaml#L274-L281

@lemon-advantage-78656 you're right It seems that we missed it during a recent change. cc @gorgeous-waitress-5026 I guess we can wrap it into a conditional in

helpers.tpl

?

Ah shoot -- sorry about that! We can either set a default empty

podLabels

value like all the other pods or wrap it in a conditional. I would probably lean towards the former.

If

values

is for defaults, empty

podLabels

is probably the most common pattern. Users should also be able to override them so adding the logic to

helpers

would be necessary too IMO

👍

the problem are the other example values files I guess

Hey guys👋I’m wondering if there is any update on this issue.

@lemon-advantage-78656 I just merged #4922 as a first step that should prevent this from happening

Awesome🎉 Then when will this fix be released?

I think the next release should carry this over (1-2 weeks from now) In the meantime you can add the change proposed there to your values file and test

Thanks for the info! While I’ve tried it before asking here😂 I don’t think it would work by adding

podLabels: {}

to value file on my end, since it is the default value that is missing, and overwriting it on my end seems not helpful, am i right?

right the conditional needs to be added to the chart that expects that field

Hmmm I don't think I'm following. Why won't a values override work?

Since override only works when default value is given, and the error I got during rendering is due to no podLabels param found.

Yeah, I don't think the conditional is necessary given the default is set in the next release

Emmm interesting! Here is override I tried, am i missing sth?

flyteagent:
  enabled: true
  podLabels: {}

That looks right to me -- my understanding might just be wrong. If you run Helm with dry-run and verbose it should show you calculated values

The original error message has to do with the map being empty. If a user enables flyteagent and leaves the podLabels map empty, AFAICT, a conditional would prevent failure

Yeah, the error is about the map being undefined (nil interface pointer)... which is why setting a default should fix it