Yini Gao
02/20/2024, 5:04 PMError: template: flyte-core/charts/flyteagent/templates/agent/deployment.yaml:17:17: executing "flyte-core/charts/flyteagent/templates/agent/deployment.yaml" at <include "flyteagent.podLabels" .>: error calling include: template: flyte-core/templates/_helpers.tpl:122:16: executing "flyteagent.podLabels" at <.Values.flyteagent.podLabels>: nil pointer evaluating interface {}.podLabels
The context is that in the value.yaml
, I set
flyteagent:
enabled: true
While if I remove the flyteagent
section in value.yaml
, it got successfully deployed.
I’m wondering if it’s relevant to the podLabels
is not configured in the default values here: https://github.com/flyteorg/flyte/blob/master/charts/flyte-core/values.yaml#L274-L281David Espejo (he/him)
02/20/2024, 5:42 PMhelpers.tpl
?Ethan Brown
02/20/2024, 8:46 PMpodLabels
value like all the other pods or wrap it in a conditional. I would probably lean towards the former.Ethan Brown
02/20/2024, 9:13 PMEthan Brown
02/20/2024, 9:15 PMenabled:true
directly in the other sample values.yaml files (control plane, data plane, etc)? If so, it might be better to take your suggestion and address this in the flyte-agent chart to be a little more defensiveDavid Espejo (he/him)
02/20/2024, 9:22 PMvalues
is for defaults, empty podLabels
is probably the most common pattern. Users should also be able to override them so adding the logic to helpers
would be necessary too IMOEthan Brown
02/20/2024, 9:25 PMEthan Brown
02/20/2024, 9:27 PMvalues.yaml
defaults from the chart with the values already written / captured in the cluster secret for the (previous) releaseDavid Espejo (he/him)
02/20/2024, 9:32 PMYini Gao
02/26/2024, 1:41 PMDavid Espejo (he/him)
02/26/2024, 1:56 PMYini Gao
02/26/2024, 1:59 PMDavid Espejo (he/him)
02/26/2024, 2:08 PMYini Gao
02/26/2024, 2:14 PMpodLabels: {}
to value file on my end, since it is the default value that is missing, and overwriting it on my end seems not helpful, am i right?David Espejo (he/him)
02/26/2024, 2:18 PMDavid Espejo (he/him)
02/26/2024, 2:20 PMDavid Espejo (he/him)
02/26/2024, 2:21 PMEthan Brown
02/26/2024, 2:33 PMYini Gao
02/26/2024, 2:36 PMYini Gao
02/26/2024, 2:37 PMEthan Brown
02/26/2024, 2:38 PMEthan Brown
02/26/2024, 2:42 PMYini Gao
02/26/2024, 2:44 PMflyteagent:
enabled: true
podLabels: {}
Ethan Brown
02/26/2024, 2:45 PMDavid Espejo (he/him)
02/26/2024, 3:10 PMDavid Espejo (he/him)
02/26/2024, 3:12 PMEthan Brown
02/27/2024, 5:14 PM