https://flyte.org logo
#contribute
Title
# contribute
e

Ethan Brown

01/31/2024, 11:00 PM
Just a heads up @David Espejo (he/him) that I've come across a number of minor issues in the charts and have a handful of PRs to put up. I'll break them up into small chunks to make them easier to review 🧵
Expose propeller webhook container port (routing bug) -> https://github.com/flyteorg/flyte/pull/4804
Add support for ingressClassName to ingress (best practice) -> https://github.com/flyteorg/flyte/pull/4805
Make sure all containers in pods pick up the new podEnv values (consistency) -> https://github.com/flyteorg/flyte/pull/4807
Add missing nodeSelectors for syncresources and webhook -> https://github.com/flyteorg/flyte/pull/4808
Define podSecurityContext / securityContext for flyte-core deployments (best practices) -> https://github.com/flyteorg/flyte/pull/4809
Add missing imagePullSecrets for the console / webhook (can't pull images without this) -> https://github.com/flyteorg/flyte/pull/4810
I've got one more that I'm going to work on finding a generic approach for if you're not already thinking about -- and that's adding an optional / configurable netpol setup. It's tricky to generalize something that will work for everyone though
2 Views