Daniel Farrell
11/08/2023, 1:01 AMdocker
to build a container from ImageSpec
with a defined Dockerfile
))
https://github.com/flyteorg/flytekit/pull/1926
wanting to get some opinions on potential changes to the ImageSpec
interface. (none implemented yet, just put the link as a reference)
Basically:
If you want to define a container for a task that Flyte manages/builds you currently must define an ImageSpec
. I would like to create a new 'builder' that builds images via a Dockerfile
, but I'm finding the current interface pretty restricted.
I find the current ImageSpec
implementation to be mainly targeted at envD
. This is strange as ImageSpec
as-is is in flytekit core, but is essentially useless without flytekit-envd
installed. The current implementation also requires flytekit-envd
to be installed on the task-node as the EnvdImageSpecBuilder
must be instantiated at task-runtime as .build gets run at some point.
I was wondering if any devs had thoughts on ways I might decouple ImageSpec
from envD
? Or if any thought has been put into this before? I have a few ideas, but each has tradeoffs and I don't want to restart discussions that have already been had.
I will say that I would like to be able to use Dockerfiles
with the least amount of modification possible, so it's not really ideal to add a pip install flytekit-docker
step to every D`ockerfile` I want to use, but maybe that is unavoidable.Samhita Alla