https://flyte.org logo
Join Slack
Powered by
hey folks! I'm trying to update our go repositori...
# ask-the-community
a
hey folks! I'm trying to update our go repositories using the monorepo latest version: 
v1.10.0
I added these requires:
Copy code
github.com/flyteorg/flyte/flyteplugins v1.10.0
	github.com/flyteorg/flyte/flytepropeller v1.10.0
And when I did a 
go mod tidy
I got something like:
Copy code
go: downloading github.com/flyteorg/flyte/flytestdlib v0.0.0-00010101000000-000000000000
go: downloading github.com/flyteorg/flyte/flyteidl v0.0.0-00010101000000-000000000000

	github.com/flyteorg/flyte/flytepropeller/cmd/controller/cmd imports
	github.com/flyteorg/flyte/flytestdlib/config: github.com/flyteorg/flyte/flytestdlib@v0.0.0-00010101000000-000000000000: invalid version: unknown revision 000000000000

	github.com/flyteorg/flyte/flytepropeller/cmd/controller/cmd imports
	github.com/flyteorg/flyte/flytestdlib/config/viper: github.com/flyteorg/flyte/flytestdlib@v0.0.0-00010101000000-000000000000: invalid version: unknown revision 000000000000

	github.com/flyteorg/flyte/flytepropeller/cmd/controller/cmd imports
	github.com/flyteorg/flyte/flytestdlib/contextutils: github.com/flyteorg/flyte/flytestdlib@v0.0.0-00010101000000-000000000000: invalid version: unknown revision 000000000000

	github.com/flyteorg/flyte/flytepropeller/cmd/controller/cmd imports
	github.com/flyteorg/flyte/flytestdlib/logger: github.com/flyteorg/flyte/flytestdlib@v0.0.0-00010101000000-000000000000: invalid version: unknown revision 000000000000

	github.com/flyteorg/flyte/flytepropeller/cmd/controller/cmd imports
	github.com/flyteorg/flyte/flytestdlib/profutils: github.com/flyteorg/flyte/flytestdlib@v0.0.0-00010101000000-000000000000: invalid version: unknown revision 000000000000
Checking the flyte repo, I'm not sure if these requires should have a proper version 
v1.10.0
there: https://github.com/flyteorg/flyte/blob/v1.10.0/flytepropeller/go.mod#L9-L11 any idea?? Happy Halloween 馃巸
Adding
Copy code
replace (
	<http://github.com/flyteorg/flyte/flyteidl|github.com/flyteorg/flyte/flyteidl> v0.0.0-00010101000000-000000000000 => <http://github.com/flyteorg/flyte/flyteidl|github.com/flyteorg/flyte/flyteidl> v1.10.0
	<http://github.com/flyteorg/flyte/flytestdlib|github.com/flyteorg/flyte/flytestdlib> v0.0.0-00010101000000-000000000000 => <http://github.com/flyteorg/flyte/flytestdlib|github.com/flyteorg/flyte/flytestdlib> v1.10.0
)
on my go.mod solved the issue, but I'm not sure if this is expected
k
We have migrated to a monorepo, but cc @Eduardo Apolinario (eapolinario)
a
Yeah, I know I鈥檓 trying to update our repo to use the monorepo dependencies
e
@Andr茅s G贸mez Ferrer, happy halloween! What you're doing (i.e. adding 
go replace
directives to map to the correct versions of the flyte modules) is the right way of pulling dependencies from the monorepo going forward.
Those pseudo versions are produced by go when you have local dependencies. Check what we're doing here for an example.
a
awesome! thank you 馃檪
FYI: @Eduardo Apolinario (eapolinario) during the update version process I detected a bug with the end_to_end flyteplugins utils I reported and fixed here: https://github.com/flyteorg/flyte/issues/4343 https://github.com/flyteorg/flyte/pull/4342 馃檪
e
oh, nice, thank you!
a
you鈥檙e welcome! 鈽猴笍
h
@Eduardo Apolinario (eapolinario) Sorry to bring this up again. It is a bit weird for user to have the replacement statement, for a repo not part of the monorepo. I understand the need of local dependencies, but in our case, it is not a local ones.
I wonder whether it makes sense to have https://github.com/flyteorg/flyte/blob/v1.10.0/flytepropeller/go.mod#L9-L11 pointing to real version in a release branch/tag?
e
@honnix, thanks for raising this concern. I debated a lot about how to make this seamless for downstream consumers, but I couldn't find a great way to handle the difference in versions.
one downside of your solution is that we'd have to be very careful about this dance of removing the replace directives and updating the versions. It's not clear to me how we to make this not-brittle. Happy to discuss though!
h
I see. It is indeed error prone. I will give this more thoughts.
Open in Slack
PreviousNext
Powered by