hey folks I m trying to update our go repositories using the

Question

hey folks I m trying to update our go repositories using the monorepo latest version `v1 10 0` I added these requires ``` github com flyteorg flyte flyteplugins v1 10 0 github com flyteorg flyte flytepropeller v1 10 0``` And when I did a `go mod tidy` I got something like ```go downloading github com flyteorg flyte flytestdlib v0 0 0 00010101000000 000000000000 go downloading github com flyteorg flyte flyteidl v0 0 0 00010101000000 000000000000 github com flyteorg flyte flytepropeller cmd controller cmd imports github com flyteorg flyte flytestdlib config github com flyteorg flyte flytestdlib v0 0 0 00010101000000 000000000000 invalid version unknown revision 000000000000 github com flyteorg flyte flytepropeller cmd controller cmd imports github com flyteorg flyte flytestdlib config viper github com flyteorg flyte flytestdlib v0 0 0 00010101000000 000000000000 invalid version unknown revision 000000000000 github com flyteorg flyte flytepropeller cmd controller cmd imports github com flyteorg flyte flytestdlib contextutils github com flyteorg flyte flytestdlib v0 0 0 00010101000000 000000000000 invalid version unknown revision 000000000000 github com flyteorg flyte flytepropeller cmd controller cmd imports github com flyteorg flyte flytestdlib logger github com flyteorg flyte flytestdlib v0 0 0 00010101000000 000000000000 invalid version unknown revision 000000000000 github com flyteorg flyte flytepropeller cmd controller cmd imports github com flyteorg flyte flytestdlib profutils github com flyteorg flyte flytestdlib v0 0 0 00010101000000 000000000000 invalid version unknown revision 000000000000``` Checking the flyte repo I m not sure if these requires should have a proper version `v1 10 0` there <https github com flyteorg flyte blob v1 10 0 flytepropeller go mod L9 L11|https github com flyteorg flyte blob v1 10 0 flytepropeller go mod L9 L11> any idea Happy Halloween jack o lantern

Andrés Gómez Ferrer · Answer

Adding ```replace v0 0 0 00010101000000 000000000000 = gt v1 10 0 v0 0 0 00010101000000 000000000000 = gt v1 10 0 ``` on my go mod solved the issue but I m not sure if this is expected

Ketan (kumare3) · Answer

We have migrated to a monorepo but cc < Eduardo Apolinario eapolinario >

Andrés Gómez Ferrer · Answer

Yeah I know I m trying to update our repo to use the monorepo dependencies

Eduardo Apolinario (eapolinario) · Answer

< Andrés Gómez Ferrer> happy halloween What you re doing i e adding `go replace` directives to map to the correct versions of the flyte modules is the right way of pulling dependencies from the monorepo going forward

Eduardo Apolinario (eapolinario) · Answer

Those pseudo versions are produced by go when you have local dependencies Check what we re doing <https github com flyteorg flyte blob v1 10 0 flytepropeller go mod L150 L155|here> for an example

Andrés Gómez Ferrer · Answer

awesome thank you slightly smiling face

Andrés Gómez Ferrer · Answer

FYI < Eduardo Apolinario eapolinario > during the update version process I detected a bug with the end to end flyteplugins utils I reported and fixed here slightly smiling face

Eduardo Apolinario (eapolinario) · Answer

oh nice thank you

Andrés Gómez Ferrer · Answer

you re welcome relaxed

honnix · Answer

< Eduardo Apolinario eapolinario > Sorry to bring this up again It is a bit weird for user to have the replacement statement for a repo not part of the monorepo I understand the need of local dependencies but in our case it is not a local ones

honnix · Answer

I wonder whether it makes sense to have <https github com flyteorg flyte blob v1 10 0 flytepropeller go mod L9 L11> pointing to real version in a release branch tag

Eduardo Apolinario (eapolinario) · Answer

< honnix> thanks for raising this concern I debated a lot about how to make this seamless for downstream consumers but I couldn t find a great way to handle the difference in versions

Eduardo Apolinario (eapolinario) · Answer

one downside of your solution is that we d have to be very careful about this dance of removing the replace directives and updating the versions It s not clear to me how we to make this not brittle Happy to discuss though

honnix · Answer

I see It is indeed error prone I will give this more thoughts