acoustic-carpenter-78188
10/18/2023, 1:16 AMerrGroup do not handle panics or goExit (but this is changing in the future).
We rely on logrus Fatalf to capture details about failures in several places in our codebase. We need to review those instances to confirm that those are not happening inside a goroutine managed by an errGroup.
We should review all instances of Fatalf and Panicf to confirm that their usage is correct.
What if we do not do this?
Graceful shutdowns, which are one of the main reasons for using errGroup, are not being handled correctly.
Related component(s)
flytepropeller, single-binary, flyteadmin
Are you sure this issue hasn't been raised already?
☑︎ Yes
Have you read the Code of Conduct?
☑︎ Yes
flyteorg/flyte