<#4253 Start metrics server in a goroutine> Pull r...
# flyte-github
a
#4253 Start metrics server in a goroutine Pull request opened by eapolinario Describe your changes Start metrics server in a separate go routine to prevent this errGroup.Wait() from hanging. As part of this investigation we realized that our usage of
errGroup
is not correct, since we mix them with panics and logrus
Fatalf
(which exit the process and set its status to 1). I opened #4255 to track this. Check all the applicable boxes ☐ I updated the documentation accordingly. ☐ All new and existing tests passed. ☐ All commits are signed-off. Screenshots Note to reviewers flyteorg/flyte Codecov: 59.04% (-0.02%) compared to a114769 Codecov: 0.00% of diff hit (target 59.06%) GitHub Actions: Build & Push Image GitHub Actions: Bump git tags ✅ 26 other checks have passed 26/30 successful checks