<#4217 Fix: Prevent unintended use of proxy author...
# flyte-github
a
#4217 Fix: Prevent unintended use of proxy authorization when no command is provided Pull request opened by fg91 Describe your changes @andrewwdye noticed that the newly introduced proxy authorization in the admin client breaks propeller, see #4216 (comment). I ran flytepropeller locally in a debugger (with the flyte-core helm chart deployed in the cluster and flyteadmin and datacatalog port-forwarded). With the debugger, I confirmed that this if statement which adds proxy authorization is hit even if no proxy command is provided in the platform config. The reason is that I check for
cfg.ProxyCommand != nil
but the default value of proxy command is empty string slice so it is never
nil
. With flytepropeller running locally in my IDE, I confirmed that: 1. with the fix introduced by this PR, the error reported by @andrewwdye is gone and that workflows can be executed again 2. that if one does configure a proxy command, that the proxy auth interceptor is still added to the dial options Check all the applicable boxes ☐ I updated the documentation accordingly. ☑︎ All new and existing tests passed. ☑︎ All commits are signed-off. flyteorg/flyte Codecov: 50.00% of diff hit (target 59.04%) ✅ 15 other checks have passed 15/16 successful checks