Join Slack
Powered by
Hi, community. I've noticed a potential inconsiste...
# flyte-support
d
damp-lion-88352
10/06/2023, 8:04 AM
Hi, community. I've noticed a potential inconsistency in our monorepo. Some files reference "flyteorg/flyteidl" instead of the updated "flyteorg/flyte/flyteidl." Here’s a list of the files I think might need a review and a check: flyteidl/setup.py:
https://github.com/flyteorg/flyte/blob/def8eb7b6f76fa552712b516b099a2576b7ee311/flyteidl/setup.py#L9
flyteidl/package.json:
https://github.com/flyteorg/flyte/blob/def8eb7b6f76fa552712b516b099a2576b7ee311/flyteidl/package.json#L2
flyteidl/protos/buf.yaml:
https://github.com/flyteorg/flyte/blob/def8eb7b6f76fa552712b516b099a2576b7ee311/flyteidl/protos/buf.yaml#L4
flytestdlib/go.mod:
https://github.com/flyteorg/flyte/blob/def8eb7b6f76fa552712b516b099a2576b7ee311/flytestdlib/go.mod#L112
flyteidl/jsonschema/workflow_execution.json:
https://github.com/flyteorg/flyte/blob/def8eb7b6f76fa552712b516b099a2576b7ee311/flyteidl/jsonschema/workflow_execution.json#L4
flyteidl/scripts/test_diff.sh:
https://github.com/flyteorg/flyte/blob/def8eb7b6f76fa552712b516b099a2576b7ee311/flyteidl/scripts/test_diff.sh#L11
flyteidl/.github/workflows/master.yml:
https://github.com/flyteorg/flyte/blob/def8eb7b6f76fa552712b516b099a2576b7ee311/flyteidl/.github/workflows/master.yml#L10-L28
Thanks a lot! Monorepo is a fantastic improvement for contributors! cc
@high-accountant-32689
h
high-accountant-32689
10/06/2023, 11:39 PM
@damp-lion-88352
, thanks for collecting those! We're in the process of cutting
flyteidl
over to the monorepo. I'll make sure that those references are also updated.
d
damp-lion-88352
10/07/2023, 12:24 AM
Thanks a lot! Really appreciate for this!
2
Views
Open in Slack
Previous
Next