cuddly-jelly-27016
10/02/2023, 5:23 PMtestutils.TearDownAndVerify is being used by several tests to verify that standard output contains certain strings. Currently, it always fails to read from the incorrect stream, and swallows the error. It never fails.
The fix uncovered two failing tests, which at quick glance seem to be valid failures and require investigation.
Type
☑︎ Bug Fix
☐ Feature
☐ Plugin
Are all requirements met?
☑︎ Code completed
☐ Smoke tested
☑︎ Unit tests added
☐ Code documentation added
☐ Any pending items have an associated Issue
Complete description
`testutils.TearDownAndVerify`:
• close the writer and read from the reader to actually verify correctness of the output in tests
• stop swallowing errors
Tracking Issue
None.
Follow-up issue
NA
flyteorg/flytectl
✅ All checks have passed
2/2 successful checksacoustic-carpenter-78188
10/02/2023, 5:23 PMacoustic-carpenter-78188
10/05/2023, 5:59 PM