acoustic-carpenter-78188
09/04/2023, 12:38 AMflytectl version reports that a new release is available, even directly after flytectl upgrade
$ flytectl upgrade
You have already latest version of flytectl
$ flytectl version
A new release of flytectl is available: 0.3.4 → v0.3.4
{
"App": "flytectl",
"Build": "8ba75a6",
"Version": "0.3.4",
"BuildTime": "2021-10-01 16:08:44.983660372 +0200 CEST m=+0.019362263"
}
Minor nitpick: the flytectl upgrade error message contains a typo (missing "the")
It seems that the version number specified in the build (used as stdlibversion.Version in <cmd/version/version.go|`cmd/version/version.go`> incorrectly omits the v of the Git tag for the release. This leads to IsVersionGreaterThan in <pkg/util/util.go|`pkg/util/util.go`> incorrectly reporting that the latest Github version is greater than the local build version.
I haven't fully grasped the release process, but it seems that the Github release action sets the version number without the v prefix in the Goreleaser action, which would explain the discrepancy.
Expected behavior
No newer release should be reported after upgrading to the latest version using flytectl upgrade.
[Optional] Additional context
To Reproduce
1. Upgrade to latest release using flytectl upgrade
2. Perform update check through flytectl version
flyteorg/flytecuddly-jelly-27016
09/04/2023, 12:38 AM