<#414 [BUG] Clean up flytekit models> Issue create...
# flytekit
a
#414 [BUG] Clean up flytekit models Issue created by wild-endeavor Describe the bug This isn't really a bug but it's also not really a feature. Flytekit currently has a series of model files that are supposed to mimic the IDL structure. For example this
ConnectionSet
class is supposed to mirror this protobuf message. Every single IDL object that's used in flytekit is mirrored in this way because the generated Python code doesn't play nicely with autocomplete and IDEs and such. It's just much nicer to work with these Python classes. In the future, we should also investigate writing a proto compiler to autogenerate these. In the meantime, there are a few inconsistencies that we've accidentally written • There are two CompiledTasks. We should remove one of them (it's not trivial, i think it causes a cyclic import somewhere). • Some of the objects like this are Admin objects, but they're not in the admin folder. We should probably move these into the admin folder. The admin folder for flytekit models should mirror the admin folder in the IDL. If not, we should at least have very good comments explaining why not. • Some of the type hints are also incorrect. We should fix these. Expected behavior Please see above. We should be careful not to break anything. Flyte component ☐ Overall ☐ Flyte Setup and Installation scripts ☐ Flyte Documentation ☐ Flyte communication (slack/email etc) ☐ FlytePropeller ☐ FlyteIDL (Flyte specification language) ☑︎ Flytekit (Python SDK) ☐ FlyteAdmin (Control Plane service) ☐ FlytePlugins ☐ DataCatalog ☐ FlyteStdlib (common libraries) ☐ FlyteConsole (UI) ☐ Other To Reproduce Steps to reproduce the behavior: NA Screenshots NA Environment Flyte component ☐ Sandbox (local or on one machine) ☐ Cloud hosted ☐ AWS ☐ GCP ☐ Azure ☐ Baremetal ☐ Other Additional context NA flyteorg/flyte
c