<#396 Fix: Mounting of secrets in kfoperators #min...
# flyte-github
a
#396 Fix: Mounting of secrets in kfoperators #minor Pull request opened by fellhorn TL;DR First step to solve flyteorg/flyte#3907 . It fixes the bug for kfoperator plugins and allows similar fixes for other k8s based plugins to mount secrets. Type ☑︎ Bug Fix ☐ Feature ☐ Plugin Are all requirements met? ☑︎ Code completed ☑︎ Smoke tested: We tested it with
Elastic
,
Pytorch
,
Tensorflow
,
MPI
and
Horovod
☐ Unit tests added ☐ Code documentation added ☐ Any pending items have an associated Issue Complete description Pods need specific labels and annotations that the mutating webhook picks them up and performs the mutations to mount the respective secrets. For plugins this did not work as these annotations were applied on the plugin object and not the
Pod
object (e.g.
PytorchJob
instead of
Pod
) Follow-up issue flyteorg/flyte#3907 still needs to be fixed for e.g. the
Dask
plugin flyteorg/flyteplugins Codecov: 19.35% of diff hit (target 63.01%) Codecov: 62.90% (-0.12%) compared to 03dc9db ✅ 5 other checks have passed 5/7 successful checks