Join Slack
Powered by
<#431 Correct comment for array job max parallelis...
# flyte-github
a
acoustic-carpenter-78188
08/08/2023, 9:35 PM
#431 Correct comment for array job max parallelism
Pull request opened by
katrogan
TL;DR
Update comment to indicate array job parallelism indicates max not min Currently, the comment
flyteidl/protos/flyteidl/plugins/array_job.proto
Line 13 in </flyteorg/flyteidl/commit/b0c083121c310f088cc41fa111ba318bff20c83e|b0c0831> implies that the parallelism field for array jobs is a min however plugins code reads the field as a max:
https://github.com/flyteorg/flyteplugins/blob/c528bb88937b4732c9cb5537ed8ea6943ff4fb56/go/tasks/plugins/array/k8s/management.go#L145
Type
☐ Bug Fix ☐ Feature ☐ Plugin ☑︎ Docs
Are all requirements met?
☑︎ Code completed ☐ Smoke tested ☐ Unit tests added ☑︎ Code documentation added ☐ Any pending items have an associated Issue
Complete description
N/A
Tracking Issue
fixes
flyteorg/flyte#3933
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/
flyteorg/flyteidl
✅ All checks have passed 13/13 successful checks
acoustic-carpenter-78188
08/09/2023, 4:02 PM
#431 Correct comment for array job max parallelism
Pull request merged by
katrogan
flyteorg/flyteidl
2
Views
Open in Slack
Previous
Next